Skip to content

Feat/migrate decoder and tests to nnx#3114

Draft
hsuan-lun-chiang wants to merge 6 commits intoAI-Hypercomputer:mainfrom
CIeNET-International:feat/Migrate-Decoder-And-Tests-to-NNX
Draft

Feat/migrate decoder and tests to nnx#3114
hsuan-lun-chiang wants to merge 6 commits intoAI-Hypercomputer:mainfrom
CIeNET-International:feat/Migrate-Decoder-And-Tests-to-NNX

Conversation

@hsuan-lun-chiang
Copy link
Collaborator

@hsuan-lun-chiang hsuan-lun-chiang commented Feb 9, 2026

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch from 7faa14d to edbbf29 Compare February 9, 2026 08:15
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 56.27706% with 202 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/nnx_decoders.py 56.59% 149 Missing and 45 partials ⚠️
src/maxtext/models/models.py 41.66% 4 Missing and 3 partials ⚠️
src/maxtext/layers/multi_token_prediction.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch 9 times, most recently from 8a3e073 to 2f30ac1 Compare February 12, 2026 11:19
@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch 6 times, most recently from 1a5740b to 5725403 Compare February 26, 2026 07:27
@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch 12 times, most recently from de4ec11 to 29a9b74 Compare March 6, 2026 09:31
@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch 2 times, most recently from 314f231 to 2f67243 Compare March 6, 2026 09:43
@charlesli640 charlesli640 force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch 6 times, most recently from 3a6b59f to e6f0231 Compare March 9, 2026 00:32
@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch 6 times, most recently from 1ee13eb to 8ed3d60 Compare March 9, 2026 10:59
@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch 3 times, most recently from 7860787 to 597e3cc Compare March 10, 2026 10:18
@hsuan-lun-chiang hsuan-lun-chiang force-pushed the feat/Migrate-Decoder-And-Tests-to-NNX branch from 597e3cc to b39893c Compare March 10, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants